Add has_many association - Githubissues

product-definition-center / pdc-ruby-gem

PDC Ruby Gem

MIT License

1 stars 7 forks source link

Add has_many association #46

Closed simozhan closed 6 years ago

simozhan commented 6 years ago

Implement simple has_many association which can help to cache result and add some test cases. As pdc gem only reads data from pdc server, this patch only implement get related association behavior, not including post action.

Known issues:

Need more test cases.
Haven't change existing api which can use has_many association like Release, will change it in future patches.

JIRA: PDC-1685

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 98.79% when pulling 4e5a14ddba83c22044aa3c59be9804c369f65129 on simozhan:add_association_has_many into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 98.79% when pulling e84d5484dbd3adeb2275724912eda920d538166c on simozhan:add_association_has_many into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 98.79% when pulling 6d199ae5084a6d91139267cc9d9515be5a441c83 on simozhan:add_association_has_many into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 98.79% when pulling 13de43ec59a4b513caa109ffb2491ac5ddd3866a on simozhan:add_association_has_many into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 98.79% when pulling f06cb84513911c48c9a19eb9c4379ae27a8ae6d4 on simozhan:add_association_has_many into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

simozhan commented 6 years ago

'API rate limit exceeded' Errors. Probably after 1 hour, the retriggering build will be green. And also @xiangge is fixing the 'API rate limit exceeded' in commit https://github.com/product-definition-center/pdc-ruby-gem/pull/45/commits/e7786d0e8f42b01c20f81865ac869c1092ee4fa2 So the patch itself has no errors, adding reviewers anyway.

coveralls commented 6 years ago

Coverage decreased (-0.2%) to 98.761% when pulling 56de980181b5992a313a574d5e2382a8597f789d on simozhan:add_association_has_many into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

simozhan commented 6 years ago

Rebase the latest codes. And add two more test cases related to reflect and custom class name.

coveralls commented 6 years ago

Coverage decreased (-0.2%) to 98.761% when pulling a42c614ed8efa70864eb694e718a011448146c0d on simozhan:add_association_has_many into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

simozhan commented 6 years ago

Dear reviewers, any new comments on this patch?

simozhan commented 6 years ago

@romanofski About the sensitive info issue, I am thinking maybe we can make the test cases internal and exclude test in gem repo, but let's think about it in another patch :)

romanofski commented 6 years ago

@simozhan I don't know... IMHO unless you have a plan it just seems that you push this decision into the future to make a plan. If it's acknowledged as a problem I suppose coming up with a mitigation process would take precedence over adding more features. No?

simozhan commented 6 years ago

@romanofski I created a new jira task in PDC-2541. Will deal with it as the next task. I will merge this patch now, that is really a long time, the rpm feature parity somehow waiting on this. We need to make a new gem to continue with other feature parity's task. Sorry about that and thanks for your review comments.