Add the belongs to association - Githubissues

product-definition-center / pdc-ruby-gem

PDC Ruby Gem

MIT License

1 stars 7 forks source link

Add the belongs to association #47

Open xiangge opened 6 years ago

xiangge commented 6 years ago

Add the belongs to association. As this our ruby gem is just used for selecting data. So not add the new/build association part.

Use can add the association in the class codes and also add a foreign_key method with the foreign key attribute return.

coveralls commented 6 years ago

Coverage decreased (-1.6%) to 97.337% when pulling e4f60d6fbc7dd7444922241ec4c32a987aa4ac35 on xiangge:associations into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-1.6%) to 97.343% when pulling c2553a1c52feecbf877be5de548ad008e3e204c3 on xiangge:associations into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-1.6%) to 97.343% when pulling fbde5786e4449447b101e041535d6d89ad7c7fbf on xiangge:associations into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on product-definition-center:master.

coveralls commented 6 years ago

Changes Unknown when pulling fcd5ac44ce7930d920090adb7579e191930dfc6d on xiangge:associations into on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling 710794949540ab4ffea7c33a849f13afb1a0a3b7 on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling fd6adfc3c0a3ced6506dbde45d12990591a37b99 on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling fe48dd878e64443e8e0b7dcb5bc39199135b9601 on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling 0f4988105772c4f06ef7c2b46198a0f0507e2abc on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling 0f4988105772c4f06ef7c2b46198a0f0507e2abc on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling 0717ecb7b8d6c667d457d589cf8ac8b309ee47d5 on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling 0717ecb7b8d6c667d457d589cf8ac8b309ee47d5 on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling f8c54cfb944b01581c1f2929a204c2b7f117418b on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling f8c54cfb944b01581c1f2929a204c2b7f117418b on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling f8c54cfb944b01581c1f2929a204c2b7f117418b on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

xiangge commented 6 years ago

Sorry for commit several time after your comments, correct several time about the blank line and space in ".rubocop.yml"

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling f8c54cfb944b01581c1f2929a204c2b7f117418b on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.256% when pulling f8c54cfb944b01581c1f2929a204c2b7f117418b on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.

simonbaird commented 6 years ago

Sorry for the slow review. It seems like it would better to squash this down into a few commits since the later commits seem like fixups and design changes. Do you want to try cleaning up the history and repushing? This should make review easier also.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 98.261% when pulling 68c950d914f04111c12351901f0740522239a83b on xiangge:associations into 7db33f4d1464759fb16c44895204fc6f54273d04 on product-definition-center:master.