search

product-definition-center / pdc-ruby-gem

PDC Ruby Gem
MIT License
1 stars 7 forks source link

Add a PRONTO_GITHUB_ACCESS_TOKEN before pronto #48

Closed xiangge closed 6 years ago

xiangge commented 6 years ago

Add a PRONTO_GITHUB_ACCESS_TOKEN before pronto to forbid 403 error when visit github api. And if you want use the secure in .travis.yml or use the Env vars in travis ci's settings, you shouldn't commit codes from a fork.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.896% when pulling 7e8b650ba1a1097f08588c6f6a9964962ad407d6 on add-token-for-pronto into f06a9be7668df9e5ad458750a6a7d8d4fe40d67a on master.

xiangge commented 6 years ago

Even we add a PRONTO_GITHUB_ACCESS_TOKEN, when we create pr from a fork, there should occur errors because the Env Vars doesn't work for forks, https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

So cancel this pr, and create a new pr #49 to fix the issue