search

product-definition-center / pdc-ruby-gem

PDC Ruby Gem
MIT License
1 stars 7 forks source link

Add faraday and curl's errors in PDC::Error #54

Open xiangge opened 6 years ago

xiangge commented 6 years ago

Add faraday and curl's errors in PDC::Error JIRA: PDC-1845

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 98.616% when pulling 212330d4c0b411f6ace427d68dea483574ae9201 on xiangge:improve-raise-error into ae37070e6f3a8c3bb6d067e87e82087ca7bce69a on product-definition-center:master.

xiangge commented 6 years ago

@sthaha the gemfile changes will push with pr #55, will rebase it after the pr is approved.

xiangge commented 6 years ago

@sthaha any updates about my new changes :)?

xiangge commented 6 years ago

@simonbaird and @simozhan please help to review this patch, after it merged, I will change the et's related codes.

xiangge commented 6 years ago

After look at the et's codes, I found there are more changes needed here.