product-os / jellyfish-ui-components

Jellyfish UI components library
Apache License 2.0
1 stars 0 forks source link

Remove redundant `getTypeFromViewCard` helper function #816

Closed LucianBuzzo closed 3 years ago

LucianBuzzo commented 3 years ago

This function is nearly identical to getTypesFromViewCard but only returns a single type and doesn't handle enums very well. Any implementation that uses the removed function should use the pluralized version instead.

Change-type: major Signed-off-by: Lucian Buzzo lucian.buzzo@gmail.com

karaxuna commented 3 years ago

We could just return first result from getTypesFromViewCard right? And it won't be major change any more. But I'm perfectly ok to remove it, you decide.

LucianBuzzo commented 3 years ago

@karaxuna I'd much rather bite the bullet and remove the redundant code