Mark All as read doesn't work - Githubissues

product-os / jellyfish

The Jellyfish Project

https://jel.ly.fish/

GNU Affero General Public License v3.0

15 stars 3 forks source link

Mark All as read doesn't work #2195

Closed mbalamat closed 5 years ago

mbalamat commented 5 years ago

Expected Behavior

Hitting mark all as read button should clear my inbox.

Actual Behavior

It doesn't mark my inbox notifications as read.

Steps to Reproduce the Problem

If mark all as read works on your account, then the issue is just on my account.

Specifications

Browser: https://whatsmybrowser.org/b/29H43NL
OS: https://whatsmybrowser.org/b/29H43NL

Screenshots

Before hitting mark all as read my console's errors: Screenshot 2019-07-15 at 12 15 50

Cleared console and hit Mark All as read button Screenshot 2019-07-15 at 12 25 30 The 12 errors are the 2 above repeated 6 times

References

FD: https://www.flowdock.com/app/rulemotion/p-cyclops/threads/q9g7pTdEM_lFSLhuteV52CxpuRk

LucianBuzzo commented 5 years ago

It looks like this issue is now resolved, likely due to the recent JSON patch changes. I'm going to add a e2e test to make sure we don't have anymore regressions.