product-os / jellyfish

The Jellyfish Project
https://jel.ly.fish/
GNU Affero General Public License v3.0
15 stars 3 forks source link

Jellyfish freezes when rendering a large timeline #4728

Closed StefKors closed 1 year ago

StefKors commented 4 years ago

Expected Behavior

Jellyfish should be fast and ligh!

Actual Behavior

The browser freezes trying to render a lot of markdown components

Steps to Reproduce the Problem

  1. for example: https://jel.ly.fish/15392a9d-756b-41c8-bc89-fcc8f67ce492

Specifications

References

https://www.flowdock.com/app/rulemotion/p-cyclops/threads/WGTRCA0LUvv-SXoXhQ_OWaVDct9

20k-ultra commented 4 years ago

I experienced the same issue on the same ticket referenced in this issue.

Memory: 32 gb CPU: i9-9880H https://www.whatsmybrowser.org/b/L1N9S

After being told a new deployment was being released I waited and tried again with the new version which I confirmed by asking what version is new. On v32.2.19 I no longer experienced lagging on the ticket that previously did.

I tried this on another laptop with same Jellyfish version (v32.2.19) and did no experience lag.

Memory: 8 gb CPU: i5-3230M https://www.whatsmybrowser.org/b/8EXBJ

StefKors commented 4 years ago

Another example: https://jel.ly.fish/a267abfb-8b4f-4e24-94a1-379675bfa645

20k-ultra commented 3 years ago

Happening to me with: https://jel.ly.fish/2bb43083-925d-43a3-9c01-182e4f26ce70

Not sure if sharing tickets is helpful. If there's anything else we can provide let us know.

20k-ultra commented 3 years ago

Actually, I just recorded the performance on the tab and we can see that this "Recalculate style" is triggering a lot.

image

Here's some more info, this might be the actual function being called.

image

jellyfish-bot commented 3 years ago

This issue has attached support thread https://jel.ly.fish/03cd0127-c105-4453-86c2-2fcf0d82cbf2

20k-ultra commented 3 years ago

Here's another really long ticket (probably the longest) I'm working on https://jel.ly.fish/59bf2cb1-16f1-4775-aa82-497c918ba879. If I don't scroll up JF will remain responsive but if it does any pagination for more comments it will trigger the style recalc mentioned above.

edit: any time I send a response comments are loaded and makes JF freeze so I can't even prevent it by not scrolling up.