product-os / landr

Repository + Landr = Website
https://getlandr.io
Apache License 2.0
3 stars 0 forks source link

Relative paths to assets (images, scripts, links) in Readme are broken #135

Closed dimitrisnl closed 5 years ago

dimitrisnl commented 5 years ago

https://dimitrisnl.github.io/wifi-connect/

Screen Shot 2019-06-25 at 2 18 24 PM

The how it works image has a relative path. We should identify paths without domain.

dimitrisnl commented 5 years ago

https://github.com/balena-io/wifi-connect

dimitrisnl commented 5 years ago

On second thought, this should be handled on Scrutinizer instead. Keeping the issue until when we upgrade to a version that has proper absolute links in Readme.

https://github.com/balena-io-modules/scrutinizer/issues/58

dimitrisnl commented 5 years ago

Tracking progress here https://github.com/balena-io-modules/scrutinizer/pull/59