search

productboardlabs / tslint-pb

📄 (DEPRECATED) Our own custom TSlint rules. What has been seen, cannot be unseen.
MIT License
5 stars 0 forks source link

`canProcessNote` is falsely marked as a selector #41

Closed opicacek closed 5 years ago

opicacek commented 5 years ago

At the beginning of the file, selector is defined under alias:

import { canProcessNote as canProcessNoteSelector } from 'selectors/InboxSelectors';

In connect dependencies, we correctly list canProcessNoteSelector selector.

Issue: canProcessNote is falsely marked by tslint as a selector.

https://github.com/productboard/pb-frontend/blob/master/src/js/modules/sidebar/components/note/NoteSidebarFooter.react.tsx#L141

jukben commented 5 years ago

🙏

Issue is that property assignment is also taken as flux dependency usage.