produvia / kryptos

Kryptos AI is a virtual investment assistant that manages your cryptocurrency portfolio
http://twitter.com/kryptos_ai
MIT License
48 stars 8 forks source link

Commission #27

Open slavakurilyak opened 6 years ago

slavakurilyak commented 6 years ago

Goal

As a developer, I want to set commission structure, so that I can have more accurate strategies based on maker and taker fees.

Consider

catalyst.api.set_commission(self, maker=None, taker=None)

Notes

  1. PerShare - Calculates a commission for a transaction based on a per share cost with an optional minimum cost per trade
  2. PerTrade - Calculates a commission for a transaction based on a per trade cost
  3. PerDollar - Calculates a commission for a transaction based on a per dollar cost

Through extensive testing of both back-testing and live-trading modes, we have reduced the commission and slippage values to account for lower volume transactions seen in some of the altcoins.

slavakurilyak commented 6 years ago

On May 23, catalyst released an update to improve the commissions calculations in live mode - documented at Live trading

bukosabino commented 6 years ago

I have added commission values to config.json and I use it on strategy.py:

   "MAKER_COMMISSION": 0.0,
   "TAKER_COMMISSION": 0.0

I think is a better way if we run with 0 commissions to start.

slavakurilyak commented 6 years ago

I think is a better way if we run with 0 commissions to start.

@bukosabino good idea! Igor Kroitor (@kroitor), one of the core developers at @ccxt, says: "It is difficult to know in advance whether your order will be a market taker or maker." (11.7.2 Trading Fees, ccxt documentation)