search

proengsoft / laravel-jsvalidation

Laravel Javascript Validation
MIT License
1.13k stars 175 forks source link

Laravel 11 support #1005

Closed Coornifex closed 8 months ago

Coornifex commented 8 months ago

Subject of the issue

Hello,

Can you add Laravel 11 support please.

Regards.

bytestream commented 8 months ago

See https://github.com/proengsoft/laravel-jsvalidation/pull/1003#issuecomment-1973952708

If it works, let me know

Coornifex commented 8 months ago

I tested and I can update composer with dev branch.

However, I have an error with JsValidator::formRequest tag :

Illuminate\Session\SymfonySessionDecorator::__construct(): Argument #1 ($store) must be of type Illuminate\Contracts\Session\Session, Illuminate\Session\SymfonySessionDecorator given, called in /home/cornifex/laravel/vendor/laravel/framework/src/Illuminate/Http/Request.php on line 578

bytestream commented 8 months ago

What's the full stacktrace?

Coornifex commented 8 months ago

https://flareapp.io/share/lm2vn0Om

bytestream commented 8 months ago

Please could you composer update and try https://github.com/proengsoft/laravel-jsvalidation/pull/1003/commits/5c35fb378bd86101d44ee280246704e516cd93a7 ?

Coornifex commented 8 months ago

It seems working fine now, thanks.

bytestream commented 8 months ago

@Coornifex please open another issue if you spot anything else. I won't be using Laravel 11 for quite some time.