prof-spock / FluidSynthPlugin

Simple Wrappers Around the FluidSynth Library as DAW Plugin and Pedantic Command Line Processor
7 stars 0 forks source link

new GUI feature build: incorrect filetype filter in Linux #8

Closed mrbumpy409 closed 7 months ago

mrbumpy409 commented 7 months ago

In the Linux build of the new GUI feature version, when browsing for a SoundFont, the filter is set as *.sf2,*.sf3. This results in no files showing. Replacing the comma with a space fixes the problem and shows both .sf2 and .sf3 files, e.g. *.sf2 *.sf3.

My OS: KDE neon User Edition 6.0 with KDE Plasma 6

prof-spock commented 7 months ago

Hello mrbumpy409,

you wrote:

the filter is set as .sf2,.sf3. This results in no files showing.

That leaves me completely puzzled: I have checked all three platforms (Windows 10, MacOSX10.15 and Ubuntu 22.04) and the selection works fine for those (see attached screenshots). Maybe - since I am using the generic file selection dialog - the filtering syntax may depend on the file manager?

On the other hand the official JUCE documentation says:

filePatternsAllowed a set of file patterns to specify which files can be selected - each pattern should be separated by a comma or semi-colon, e.g. "" or ".jpg;*.gif"

Could you kindly try whether a semicolon works on your system? Anyway, I'll find out and keep you informed.

Best regards, Prof. Spock Windows-FileSelectionDialog Windows

MacOSX-FileSelectionDialog MacOSX

Ubuntu-FileSelectionDialog Ubuntu

mrbumpy409 commented 7 months ago

Strange. I'll admit I don't know a lot about how this is all supposed to work, and the bug could be in JUCE or the KDE file picker. Anyway, here is what I get with a comma (and also same result with a semicolon): image

And here it is with a space instead: image

Interestingly, the GNOME file picker from your Ubuntu screenshot shows a space in the file filter.

prof-spock commented 7 months ago

Yep, I'll try whether space works for all platforms even though the JUCE documentation suggests otherwise...

mrbumpy409 commented 7 months ago

Hey, using a semicolon in the source code instead of a comma results in success on my system. With the source code as *.sf2;*.sf3, when the file picker comes up, it shows the file types separated by a space (*.sf2 *.sf3), and everything works.

prof-spock commented 7 months ago

Hello mrbumby409,

I've revised the filtering according to your suggestion.

Best regards, Prof. Spock

mrbumpy409 commented 7 months ago

Everything is working great now. Thanks!

prof-spock commented 7 months ago

part of release 0.7.0, see release notes