search

prof79 / fansly-downloader-ng

Easy-to-use fansly.com content downloading tool. Written in Python and available as a standalone Windows Executable. Enjoy your Fansly content offline anytime, anywhere in the highest possible content resolution! Fully customizable to download in bulk or single: photos, videos & audio from timeline, messages, collection & single posts.
GNU General Public License v3.0
267 stars 15 forks source link

Add a `show_skipped_downloads` setting #26

Closed sunbart closed 6 months ago

sunbart commented 7 months ago

Adding a new option that allows for "skipped file" log messages to be hidden, to make logs shorter and easier to read, especially when running regularly as a cronjob. The amount of skipped files is reported in a summary log line, per cursor where applicable and only if show_downloads is enabled.

Caveats

When a file is skipped by hashing deduplication, the file download message is still shown, but the dedupe line isn't. And the summary at the end of the cursor still counts it into the skipped amount, which is (in my opinion slightly) counter-intuitive. We could still show the hash-based dedupe log line to spell out exactly what happened in this case.

The functionality is not tested in the collection download mode, as I don't have a collection to test with. Thanks to the modular structure, the actual hiding of the log message will work, but the summary of skipped files might not work right. Timeline, messages and single modes I've tested to the best of my ability.

prof79 commented 6 months ago

Thanks, looks very good 👍 - but I want to go/think over it once more when I have more time/do a coding session for other issues.

Yes, hash deduplication is a chicken-and-egg problem - you need to download to tell whether it already exists or not.

I'm also not a collections guy 😊 (but I guess we could even make them ourselves and bookmarking stuff into them)

prof79 commented 6 months ago

Skipped items statistics: Maybe I have a misunderstanding or you have another perspective on this (I can also see why): Since statistics are there people may get anxious when items are missing. So the take a look at the total num of pics & vids of the creator either on the page or the downloader also retrieves and shows this info. So if you download a file for analysis and it is already there - it must be counted as skipped or the figures at the end will never add up. Though I agree handling re-posts and factoring them in statistically is a hairy topic and the code is certainly not bulletproof yet.

prof79 commented 6 months ago

Download message: Recently (in the restroom, as often 😂) I had a grand idea - the download message should be shown after dedup analysis and changed to "Downloaded ...". Maybe put some "Analyzing ..." message before/in the timeline. But for now I'll accept this PR as-is and worry about improvements later, maybe this weekend. Had helluva work week, need to recharge my batteries a bit.