Fix scrolling

[H3rnand3zzz]

Current state:

• Fixes "overscrolling"
• Lag reduction (only necessary lines are being drawn)

Currently it's full of debugging lines with some issues which are to be fixed before release:

• [x] Fix "underscrolling"
• [x] Fix "overscrolling" (profanity jumps over big messages received from DB)
• [x] Change line calculation (made based on curses' position)
• [x] Cleanup debug lines
• [x] Merge
• [x] Fix a problem: extremely big message (e.g. 3k lines) causes profanity to jump back once scrolled on top

This line is for github CI/CD system to link the issue

Fix https://github.com/profanity-im/profanity/issues/1934

[H3rnand3zzz]

New revision

• Git commit description is removed for now since a lot of things are subject to change.
• New approach: let ncurses calculate lines instead of trying to do it by ourselves. Passing numbers of lines in the buffer helped to resolve overscrolling problem and can be handy in the future (jumping to some messages (unread, search), visual selection of messages etc.).
• Underscrolling is broken again since some numbers are off in line calculation (though they are mostly correct, it's likely caused by some edge cases), requires further investigation.

[H3rnand3zzz]

New revision

• Pass id from DB (I am not sure if it's correct, probably stanza-id should be passed, but also we should consider LMC case)
• Increase PAD_SIZE from 1000 to 10000, it helps rendering in the background, as well as with lines amount calculation
• More debug lines (to be removed before staging)

[H3rnand3zzz]

New revision

• Commit message that outlines changes
• Merged with the latest changes
• Added fetching stanza_id from the DB (changes are highly interconnected)
• Removed debug messages

[H3rnand3zzz]

New revision

• Comments are removed as per @sjaeckel's request.
• Variable renamed for more consistent style

[jubalh]

Pass id from DB (I am not sure if it's correct, probably stanza-id should be passed, but also we should consider LMC case)

What were your thoughts here exactly? I think id that you used is correct.

[H3rnand3zzz]

New revision

Addressed the issues outlined in the review.

[H3rnand3zzz]

addressed

[jubalh]

Fix a problem: extremely big message (e.g. 3k lines) causes profanity to jump back once scrolled on top

Was this already the case before your change? I'm not even sure 3k lines fit on a screen? :D

[H3rnand3zzz]

New revision

• Removed buffer limitation based on amount of lines in messages: it might affect users who don't use history, the approach has a good idea, but requires more careful implementation (e.g. limitation on amount of drawn lines as opposed to stored lines)
• Description updated
• Rebased on master

[jubalh]

it might affect users who don't use history, the approach has a good idea, but requires more careful implementation

Affect how? Should we wait with merging/reviewing the code before this is solved? I would prefer to not include something "wrong" in master because several of our users use master to help us find bugs. So this might annoy them or make them report something that we are aware of.

[H3rnand3zzz]

it might affect users who don't use history, the approach has a good idea, but requires more careful implementation

Affect how? Should we wait with merging/reviewing the code before this is solved? I would prefer to not include something "wrong" in master because several of our users use master to help us find bugs. So this might annoy them or make them report something that we are aware of.

It might've affected in a previous version, currently it was removed, hence no one should be affected in any negative way (at least I don't see a problem currently, I might've missed something obviously).

[H3rnand3zzz]

New revision

• Fixed the issue pointed out above (buffer wasn't limited at all)