search

profanity-im / profanity

Ncurses based XMPP client
https://profanity-im.github.io/
Other
1.32k stars 187 forks source link

Iconsistent status message when downloading files #1939

Open mdosch opened 11 months ago

mdosch commented 11 months ago

When downloading a file in an OMEMO chat by typing /url save <tab> /tmp which expands to e.g. /url save https://files.mdosch.de/upload/ZJZ9Fjkr6zKwlDeOp0gd7HLS/test.txt /tmp/ profanity shows:

Downloading 'https://files.mdosch.de/upload/xnsfVl6uH4rxlRDOxBNOiFfR/FQAhbVXpSV62ZTmm2e26RA.txt':
done
Saved to '/tmp/profanity.4WRQF2'

But the file is at /tmp/FQAhbVXpSV62ZTmm2e26RA.txt (like I expected) and not at /tmp/profanity.4WRQF2.

When doing the same in an unencrypted (no e2ee) chat there is no Downloading… message at all but the file is downloaded.

Expected Behavior

In an OMEMO chat profanity should show the real location of the file in the status message. In a no-e2ee chat I would expect profanity to also show the message about downloading the file.

Environment

profanity --version
Profanity, version 0.14.0dev.master.0e66cbe4
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2023 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Disabled
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Disabled
GTK icons/clipboard: Disabled
GDK Pixbuf: Enabled
jubalh commented 7 months ago

@mdosch did the above mentioned PR fix this enough?

mdosch commented 7 months ago

I'll try to check this weekend.

On 21.03.2024 04:59, Michael Vetter wrote:

@mdosch did the above mentioned PR fix this enough?

-- Reply to this email directly or view it on GitHub: https://github.com/profanity-im/profanity/issues/1939#issuecomment-2012082954 You are receiving this because you were mentioned.

Message ID: @.***>

mdosch commented 7 months ago

Just now I wanted to save a OMEMO file under a certain name:

/url save REDACTED ~/Documents/bla.pdf

Profanity showed Saved to '/tmp/profanity.O0SCL2' but I found the document under ~/Documents/bla.pdf/$randomnamechosenbyconversations.pdf.

On 21.03.2024 04:59, Michael Vetter wrote:

@mdosch did the above mentioned PR fix this enough?

-- Reply to this email directly or view it on GitHub: https://github.com/profanity-im/profanity/issues/1939#issuecomment-2012082954 You are receiving this because you were mentioned.

Message ID: @.***>