search

profcab / simile-widgets

Automatically exported from code.google.com/p/simile-widgets
0 stars 0 forks source link

TIMEPLOT: data off by 1 day #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
if you view the demo of timeplot on your website then view the data file
that you are linking it to, you will notice that the data is off by 1 day.

Original issue reported on code.google.com by KBrog...@gmail.com on 1 Aug 2008 at 7:40

GoogleCodeExporter commented 9 years ago 
Edited subject. Note that Timeplot does not have any active maintainers. Your 
help 
would be appreciated.

Original comment by larryklu...@gmail.com on 25 Sep 2008 at 5:12

GoogleCodeExporter commented 9 years ago 
Here's an example of (I believe) the same thing in the wild; where the labels 
are off
by a year (2007 should be 2008, etc):
http://test.musicbrainz.org/show/stats/timeline.html

Original comment by voiceins...@gmail.com on 23 Nov 2008 at 1:47

GoogleCodeExporter commented 9 years ago 
The cause of this bug is the way Timeplot finds a value for times in between 
the 
actual datapoints. The value of the first datapoint AFTER the given time will 
always 
be used, no matter how far away it is.

Example:
data:
2008.12.01,10
2008.12.20,50

Given the date and time 2008.12.01T00:00:01, Timeplot will see that this is one 
second after the first datapoint, and therefore return the next datapoint which 
is 
50.

When mouse coordinates are translated to date and time, the result will 
(almost) 
never be exactly at midnight, and therefore the wrong value will be returned.

I think that a better solution is to have the labels always snap to the closest 
datapoint of where the mouse is moved, and present that date and value, instead 
of 
presenting values for dates that doesn't actually exist in the underlying data. 
I 
have attached two diff-files for plot.js and sources.js that will make this 
change. 
The diff-files are created as a comparison to revision 1727.

NOTE: The file timeplot-bundle.js will need to be re-built to include these 
changes.

Original comment by jon.a.am...@gmail.com on 30 Dec 2008 at 1:30

Attachments:

GoogleCodeExporter commented 9 years ago 
processor.js also requires a change, but patch accepted and committed otherwise.

Original comment by ryan...@csail.mit.edu on 15 Jan 2009 at 8:46