profclems / glab

The GitLab CLI tool. Archived: now officially adopted by GitLab as the official CLI tool and maintained at https://gitlab.com/gitlab-org/cli. See https://github.com/profclems/glab/issues/983
https://glab.readthedocs.io/
MIT License
2.08k stars 163 forks source link

do not navigate, when we don't have jobs loaded yet. #1001

Closed okias closed 2 years ago

okias commented 2 years ago

Description

Catch out-of-bound exception

Related Issue

Resolves https://github.com/profclems/glab/issues/991

How Has This Been Tested?

Runtime tested, on linux, amd64

Screenshots (if appropriate)

Types of changes

okias commented 2 years ago

Would be nice to have something like "Loading the pipeline..." or something informative on screen. what do you people think?

clemsbot commented 2 years ago

This PR has been automatically marked as stale because it has not had recent activity. This message is just a reminder for the author, reviewers and assignees.

okias commented 2 years ago

not stale, please merge. Also DeepSource: Go seems to noticed unrelated issues(?)

profclems commented 2 years ago

Hi @okias, thanks a lot for this PR. I love this, however, we announced that this project is officially adopted by GitLab https://github.com/profclems/glab/issues/983#issue-1175723125. All new contributions should be made to the GitLab repo: https://gitlab.com/gitlab-org/cli

okias commented 2 years ago

@profclems thanks, moved to https://gitlab.com/gitlab-org/cli/-/merge_requests/1012