profclems / glab

The GitLab CLI tool. Archived: now officially adopted by GitLab as the official CLI tool and maintained at https://gitlab.com/gitlab-org/cli. See https://github.com/profclems/glab/issues/983
https://glab.readthedocs.io/
MIT License
2.08k stars 163 forks source link

fix: fix validation for GitLab 14.5 tokens #971

Closed ygarasab closed 2 years ago

ygarasab commented 2 years ago

Description

This solves the current gitlab.com issue with the command

glab auth status

But there are still some warning messages related to some db.org and gl.io domains, but I don't really know what that's about :(

Related Issue

Resolves #926

How Has This Been Tested?

Local testing

Screenshots (if appropriate)

Types of changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #971 (3ea05c9) into trunk (ce81f27) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #971   +/-   ##
=======================================
  Coverage   59.51%   59.51%           
=======================================
  Files          97       97           
  Lines        7687     7687           
=======================================
  Hits         4575     4575           
  Misses       2702     2702           
  Partials      410      410           
Impacted Files Coverage Δ
commands/auth/status/status.go 91.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce81f27...3ea05c9. Read the comment docs.

ygarasab commented 2 years ago

I'm gonna give a go at the tests :D, never tested in go though