search

profcturner / WAM

Workload Allocation Modeller and Assessment Approval System
GNU Affero General Public License v3.0
4 stars 0 forks source link

Handle "past" signoffs better - in terms of notifications #47

Open profcturner opened 2 years ago

profcturner commented 2 years ago

Currently there are numerous dire warnings when a user tries to sign off an assessment state for a work package in the past - because this is usually a mistake that they haven't moved to the current academic year.

The dire warnings are still periodically ignored in such mistaken circumstances, and the system is set up not to send notifications (by default); however, this leads to the problem being rolled through each cron job. It may be better to:

  1. just set a notification time and no notifications
  2. send a notification only to the user sending the sign off, warning them yet again, and asking them to forward manually if it's correct
  3. send a notification to all potential parties, but warning them about the past sign off status
  4. disallow all such sign offs.

I'm not sure which option is best, yet.

profcturner commented 2 years ago

Another possibility is we add a flag so the issue is only logged once, but in fact this probably still means something accidental has occured.

Or yet another confirmatory step.