proferabg / EdiZon-Overlay

EdiZon Overlay originally by WerWolv. Updated for HOS 18.0.1
256 stars 24 forks source link

random crashes #12

Closed mayt04 closed 1 year ago

mayt04 commented 1 year ago

Basically sometimes when i open the tesla overlay menu it disappears and then atmosphere crashes,im using the atmosphere pre relase. im on firmware 16 .Im trying to use a pokemon violet cheat file Link of the cheat txt and crash log:https://drive.google.com/drive/folders/1IOCa3sk2p-TvzxKWhUdbexRxWNPVw7fy?usp=share_link

ELY3M commented 1 year ago

It is still crashing.... :( https://youtu.be/tlBxGSNEMCA

ELY3M commented 1 year ago

crash logs here 4-2-23-crash-logs-with-proferabg.zip

fennectech commented 1 year ago

If you need any testing. Logging. Or any stuff I’ve got a dev environment set up and am willing to contribute my time and switch twards fixing this.

masagrator commented 1 year ago

crash logs here 4-2-23-crash-logs-with-proferabg.zip

Curious enough, it's not data abort like in previous cases, but instruction/prefetch abort - which sounds like issue with memory corruption.

It is still crashing.... :( https://youtu.be/tlBxGSNEMCA

Yup, this is not how bug which I fixed works. You are only hiding overlay while patched bug happens only on exiting overlay.

ELY3M commented 1 year ago

Do I need to exit my overlay fully every time I change the cheat?

masagrator commented 1 year ago

you don't even need to enable any cheat. Just open Edizon, close Edizon, and so on. If no crash 0x4A8 happens in like let's say 50 times of opening/closing in handheld and docked mode, then bug related to my PR is fixed.

If this is a bug with Edizon specifically, then we don't know what's causing it. Maybe running in background too long is an issue for it? It doesn't help the fact that it requires dmnt:cht to work, so GDB cannot be used to debug it. :D I guess dev could try to block dmnt:cht use, and fake enabling/disabling cheats to check if crash will still occur. Then it could be debugged.

ELY3M commented 1 year ago

I figured out why I am crashing. It was from that I hide and unhide the overlay.... I have to fully exit the overlay after switching cheats. you press on touch screen to hide overlay..... and press buttons to unhide it.
no crashes if I exit fully every time I change cheats by pressing B till overlay close.

proferabg commented 1 year ago

It doesn't help the fact that it requires dmnt:cht to work, so GDB cannot be used to debug it. :D I guess dev could try to block dmnt:cht use, and fake enabling/disabling cheats to check if crash will still occur. Then it could be debugged.

Cheats are pulled from dmnt:cht service so I would have to make fake menus to test that. Here is the build that should allow GDB if the only thing it is looping on is the dmnt:cht service. https://github.com/proferabg/EdiZon-Overlay/issues/17#issuecomment-1494405890

fennectech commented 1 year ago

I got the crash every 3 of 4 times

fennectech commented 1 year ago

I'm up and able to troubleshoot it, ping me and let me know if you need me to do anything

ELY3M commented 1 year ago

@fennectech Do you full close the overlay when you done with changing cheats?

ELY3M commented 1 year ago

this is what not to do....

https://www.youtube.com/watch?v=DjPwEx8cAuk

now, I have no crashes if I press B couple times to exit the overlay fully.

fennectech commented 1 year ago

I’ve seen the issue with all overlays. Not just Edison.   So no.  Sent from my iPhoneOn Apr 3, 2023, at 8:38 PM, ELY M. @.***> wrote: @fennectech Do you full close the overlay when you done with changing cheats?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

masagrator commented 1 year ago

If it's not in Edizon only that unhiding crashes overlay randomly, it can be debugged. I will try to see if I can replicate that in other overlays when I will be back in home.

masagrator commented 1 year ago

Tried like 50 times with FPSLocker through 10 minutes with changing settings and no crash

fennectech commented 1 year ago

I’ve been

If it's not in Edizon only that unhiding crashes overlay randomly, it can be debugged. I will try to see if I can replicate that in other overlays when I will be back in home.

It’s only happening when docked. Almost every time i open an overlay the console fatals.

lowburger commented 1 year ago

I’ve been

If it's not in Edizon only that unhiding crashes overlay randomly, it can be debugged. I will try to see if I can replicate that in other overlays when I will be back in home.

It’s only happening when docked. Almost every time i open an overlay the console fatals.

Man you are total behind in this and won't help developer...

Instant crash and dock crash is fix. This issue for edizon overlay only.

fennectech commented 1 year ago

Oh! I'll see about updating and see if I can recreate it. Sorry about the confusion.

fennectech commented 1 year ago

I've just recompiled ovlmenu and ovlsysmodules with latest libnx (from master not dkp) and latest libtesla and am still getting fatals when opening overlays from ovlmenu while docked. Im unsure what I'm doing wrong. My discord is FennecTECH#4926 if you'd like to take this somewhere else as it seems unrelated to the issue you guys are troubleshooting here.

ELY3M commented 1 year ago

I also rebuild my atmosphere with latest libnx. it seem helping in my case.

ELY3M commented 1 year ago

for @fennectech https://github.com/ELY3M/Atmosphere/releases/tag/1.5.1-latest-libnx

ELY3M commented 1 year ago

I did a test in docked mode too. no crashes as I am exiting the overlay properly.

masagrator commented 1 year ago

from master not dkp

This PR was not accepted yet to master, so no wonder it's not working.

Dunno for what they are waiting for.

masagrator commented 1 year ago

@proferabg proper fix was implemented into main libnx. Would you release an update with this fix?

ninjastarforcex commented 1 year ago

Basically sometimes when i open the tesla overlay menu it disappears and then atmosphere crashes,im using the atmosphere pre relase. im on firmware 16 .Im trying to use a pokemon violet cheat file Link of the cheat txt and crash log:https://drive.google.com/drive/folders/1IOCa3sk2p-TvzxKWhUdbexRxWNPVw7fy?usp=share_link

I'm having an EXACT SAME PROBLEM and still haven't solved the issue I tried opening EdiZon on a game that has no Cheat and it still crashes sometimes it doesn't crash, but more often than not, it crashes.

proferabg commented 1 year ago

@proferabg proper fix was implemented into main libnx. Would you release an update with this fix?

Sorry I am so late on this, I have been largely away and haven't been able to build it. https://github.com/proferabg/EdiZon-Overlay/releases/tag/v1.0.6

For everyone else:

If you are crashing when opening and closing the menu, please back out all the way to close it. This is a known bug and is currently being worked on!

proferabg commented 1 year ago

Version 1.0.7 should fix the known crashing issues and mismatched cheats bug on hiding and showing the overlay without backing all the way out of the overlay. I am going to close this issue now and if any more crashing issues occur outside of what is now fixed, another issue can be opened up.