search

profesorfalken / jPowerShell

Simple Java API to interact with PowerShell console
Apache License 2.0
218 stars 84 forks source link

Improve Timeout and Error Handling v2 #41

Open Harinus opened 6 years ago

Harinus commented 6 years ago

Greetings profesorfalken,

I am still using your library and wanted to share some improvements I did. This is basically a replacement for #22. See the two commit messages below for details and the description of the original PR. I have noticed your comments and simplified my changes. However those are quite important IMO for error and timeout handling and already very well tested with about 0.5 million executions in my environment.

There is just one thing I noticed and that can possibly not be fixed: Once someone uses "throw" or "return" in their powershell script it will terminate it and therefore never read the end tag from the stream. (Affects both your and my version). Maybe add that to the documentation just in case.

Hopefully this can be merged so, I can switch back to the main branch and get rid of my custom version.

Best regards, Harinus

profesorfalken commented 6 years ago

Hi, I will check your branch

Thanks