search

professor / whiteboard

Carnegie Mellon University - Silicon Valley Campus - Learn By Doing Curriculum Tool
37 stars 61 forks source link

Modify people search to illustrate how to use query params #157

Open professor opened 11 years ago

professor commented 11 years ago

How do we want to document this? I don't want to clutter your page. Perhaps we put it in ruby doc and link to a web page? If we take care of the other issue, this one might go away.

kaushikgopal commented 11 years ago

We could add a single line showing the link being built (within the advanced search parameter box itself), as they keep adding filters?

professor commented 11 years ago

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal notifications@github.com wrote:

We could add a single line showing the link being built (within the advanced search parameter box itself), as they keep adding filters?

— Reply to this email directly or view it on GitHub.

kaushikgopal commented 11 years ago

I was thinking of that, but wouldn't that force a page refresh when we modify the url string?

On Wednesday, January 23, 2013, Todd Sedano wrote:

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal notifications@github.com wrote:

We could add a single line showing the link being built (within the advanced search parameter box itself), as they keep adding filters?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/professor/cmusv/issues/157#issuecomment-12635289.

professor commented 11 years ago

I don't think so - see google mail

Sent from my iPhone

On Jan 23, 2013, at 8:04 PM, kaushikgopal notifications@github.com wrote:

I was thinking of that, but wouldn't that force a page refresh when we modify the url string?

On Wednesday, January 23, 2013, Todd Sedano wrote:

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal notifications@github.com wrote:

We could add a single line showing the link being built (within the advanced search parameter box itself), as they keep adding filters?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/professor/cmusv/issues/157#issuecomment-12635289.

— Reply to this email directly or view it on GitHub.

professor commented 11 years ago

Lets do bobs idea first, we might not need to document the query parsms as one can always look at the code.

Sent from my iPhone

On Jan 23, 2013, at 8:04 PM, kaushikgopal notifications@github.com wrote:

I was thinking of that, but wouldn't that force a page refresh when we modify the url string?

On Wednesday, January 23, 2013, Todd Sedano wrote:

Maybe we update the query string in JavaScript as filters are chosen

Sent from my iPhone

On Jan 23, 2013, at 5:04 PM, kaushikgopal notifications@github.com wrote:

We could add a single line showing the link being built (within the advanced search parameter box itself), as they keep adding filters?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/professor/cmusv/issues/157#issuecomment-12635289.

— Reply to this email directly or view it on GitHub.

kaushikgopal commented 11 years ago

just noticed a way of editing the existing url without refreshing the page (using HTML5 history-api) : http://warpspire.com/experiments/history-api/