search

professor / whiteboard

Carnegie Mellon University - Silicon Valley Campus - Learn By Doing Curriculum Tool
37 stars 61 forks source link

Alertify style dialog for auto-saved changes #205

Closed kaushikgopal closed 11 years ago

kaushikgopal commented 11 years ago

Implemented only for pages.

If this looks like something we will use, I'll add it into the peer evaluations.

professor commented 11 years ago

This is close to what we talked about. I find showing the message every 10 seconds to very distracting. I would suggest that a message saying "Auto save enabled" or "We'll save your changes every 10 seconds" on page load or when the text box is edited for the first time.

kaushikgopal commented 11 years ago

@professor agreed it can get quite annoying to have this constantly pop up. I've made changes to only show the message if auto-save is enabled for the page. so it'll show up once on page load. If you prefer this, I'll add it to peer-evaluation as well.

professor commented 11 years ago

I'm accepting the pull request, please do the same for peer evaluation.

Todd Sedano Director of Software Engineering Carnegie Mellon University Silicon Valley Campus Developing Software Leaders (TM) T: 650-335-2812

On Thu, May 23, 2013 at 11:41 AM, kaushikgopal notifications@github.comwrote:

@professor https://github.com/professor agreed it can get quite annoying to have this constantly pop up. I've made changes to only show the message if auto-save is enabled for the page. so it'll show up once on page load. If you prefer this, I'll add it to peer-evaluation as well.

— Reply to this email directly or view it on GitHubhttps://github.com/professor/whiteboard/pull/205#issuecomment-18363294 .

kaushikgopal commented 11 years ago

done. added to peer evaluation as well.

On Thu, May 23, 2013 at 2:42 PM, Todd Sedano notifications@github.comwrote:

I'm accepting the pull request, please do the same for peer evaluation.

Todd Sedano Director of Software Engineering Carnegie Mellon University Silicon Valley Campus Developing Software Leaders (TM) T: 650-335-2812

On Thu, May 23, 2013 at 11:41 AM, kaushikgopal notifications@github.comwrote:

@professor https://github.com/professor agreed it can get quite annoying to have this constantly pop up. I've made changes to only show the message if auto-save is enabled for the page. so it'll show up once on page load. If you prefer this, I'll add it to peer-evaluation as well.

— Reply to this email directly or view it on GitHub< https://github.com/professor/whiteboard/pull/205#issuecomment-18363294> .

— Reply to this email directly or view it on GitHubhttps://github.com/professor/whiteboard/pull/205#issuecomment-18373722 .