Porting to Manifestv3 - Githubissues

proffapt / fERP

Stands for Feedback-ERP. Automation extension for IIT KGP ERP feedback

https://youtu.be/uUf2_91boco

GNU Affero General Public License v3.0

39 stars 13 forks source link

Porting to Manifestv3 #24

Closed harshit-jain52 closed 8 months ago

harshit-jain52 commented 11 months ago

What?

Modified manifest.json to v3

Closes #22

ToDo

[x] update manifest.json
[x] update main.js
[ ] update feedback.js

harshit-jain52 commented 11 months ago

I have implemented the changes that I could find here. Can we check if they're working or not?

proffapt commented 11 months ago

doesn't feedback.js require changes?

harshit-jain52 commented 11 months ago

doesn't feedback.js require changes?

None that I could find. I'll search again.

proffapt commented 11 months ago

Then ig wait for the feedback form to open or create something to test for it, I had the feedback form downloaded but my device was repaired so had to format ssd :/

harshit-jain52 commented 8 months ago

How exactly to test the software on a particular branch?. I mean, this PR hasn't been merged, but i wanna test this. Sorry I don't have any JS experience.

proffapt commented 8 months ago

You have the code in your local right? Follow the steps in the readme to install them manually.. for firefox you will have to zip the extension using web-ext build.

You may search for "How to install extension manually on chrom/firefox"

proffapt commented 8 months ago

https://github.com/proffapt/fERP?tab=readme-ov-file#firefox -> Manual part https://github.com/proffapt/fERP?tab=readme-ov-file#chromium-based-browsers

harshit-jain52 commented 8 months ago

It seems the registration of event listeners in feedback,js has to be changed. I'm not sure how.

proffapt commented 8 months ago

Closing this, since I will be working on it rn, thanks for the efforts <3