profi200 / open_agb_firm

open_agb_firm is a bare metal app for running GBA homebrew/games using the 3DS builtin GBA hardware.
GNU General Public License v3.0
849 stars 42 forks source link

Screen brightness thing #180

Open DenizAydin01 opened 2 months ago

DenizAydin01 commented 2 months ago

When on old 3ds device, Opened rosalina menu. In change screen brightness sub menu, you can see screen luminance values between 16 and 142. So i wonder why does it say minimum 20 in readme.md for old 3ds devices. Because 16 and 142 isnt just there like sembolic things it actually works and i can see the screen getting slowly dimmer between 16 and 20 via using luma3ds menu. Also when setting old 3ds's brightness without cfw normally between 1-5 levels, 5 sets it to 142 and 1 sets it to 16. Instead of 20 and 117

profi200 commented 2 months ago

I'm not sure where the old limits come from but the old brightness system is based on PWM duty cycles which is not great but was easy to implement. The new system used in the libn3ds_gfx_lgycap branch uses luminance and requires hardware calibration. Current Luma versions also show luminance if i remember correctly.

DenizAydin01 commented 2 months ago

I'm not sure where the old limits come from but the old brightness system is based on PWM duty cycles which is not great but was easy to implement. The new system used in the libn3ds_gfx_lgycap branch uses luminance and requires hardware calibration. Current Luma versions also show luminance if i remember correctly.

So is it okay if i leave the brightness config set to 16 in config.ini file for an old 3ds xl, will it even do anything?

profi200 commented 2 months ago

It will likely get set back to 20 somewhere. I don't even know if we are talking about luminance or PWM duty cycle here. It does matter because brightness is not linear.