profi200 / open_agb_firm

open_agb_firm is a bare metal app for running GBA homebrew/games using the 3DS builtin GBA hardware.
GNU General Public License v3.0
908 stars 44 forks source link

Classic NES series roms gives GAMEPAK ERROR #3

Closed Dartz150 closed 4 years ago

Dartz150 commented 4 years ago

See this for reference https://mgba.io//2014/12/28/classic-nes/

profi200 commented 4 years ago

Did you set the save type and size correctly? It's impossible for this to fail because it uses GBA hardware.

Dartz150 commented 4 years ago

I'm certain I did, I will test other Classic NES roms as I have been only using one.

profi200 commented 4 years ago

Got it to work? Also delete the save file when trying different save types.

profi200 commented 4 years ago

Closing for inactivity.

Dartz150 commented 4 years ago

Gonna bump this as I have made tests with the latest commit and the issue still persist, tried every available rom of the classic NES series from every region, all leading to the same "GAME PAK ERROR" issue. It may be related to an incorrect save type detection.

The save type detected on this type of games is 'EEPROM_V124', I tried to start the games with no save file and with previous save file created with mGBA, both scenarios have the issue.

profi200 commented 4 years ago

Did you make sure the dump is a known good one? https://datomatic.no-intro.org/?page=search

I'm gonna do some tests myself.

profi200 commented 4 years ago

I can confirm this but unsure why it's happening. Possibly the builtin hardware that "emulates" the save chip is not as accurate as it should. These games use various tricks most of which should be no problem at all to handle for the hardware GBA mode.

See: https://mgba.io/2014/12/28/classic-nes/

edit: Got it working by overriding the save type with EEPROM_8k (not 8k_2).