search

profi200 / open_agb_firm

open_agb_firm is a bare metal app for running GBA homebrew/games using the 3DS builtin GBA hardware.
GNU General Public License v3.0
860 stars 42 forks source link

Video scaler options don't appear to do anything #61

Closed RueGorE closed 2 years ago

RueGorE commented 2 years ago

I tried changing the video scaler options in the config.ini between 0, 1, and 2 but the output appears exactly the same in every case. I even dumped the screen output on each mode and as far as I can tell they're not different from each other in any way. I would prefer to play with a bilinear filtered output. Is this config option just not supported yet?

profi200 commented 2 years ago

Make sure every config option is in its own line. The last release creates a default config file where one newline is missing.

RueGorE commented 2 years ago

Yes, every config option is on its own line. Despite this, changing scaler still doesn't do anything. BTW I am using the latest release. Am I correct in assuming scaler option 0 is supposed to output a 1:1 image, 240x160 pixels? It just remains at the full size of the 3DS screen.

profi200 commented 2 years ago

See the comment in this line or the readme for the scaling options.

Make sure the config is in the right place. It's "/3ds/open_agb_firm/config.ini" for a while now. If this isn't the problem then i don't know what's wrong. Maybe reformat your SD card.

RueGorE commented 2 years ago

I downloaded a fresh new copy of oaf onto another 3DS. Ran oaf for the first time on it to have it automatically create config.ini in the default sdmc:/3ds/open_agb_firm/ directory. As it had with my first 3DS, the config file did not have the scaler option listed anywhere, so I dropped a newline and put it between [video] and gbaGamma=2.2. I entered scaler=1. Saved and ran oaf. And the output still isn't bilinear. Then I changed it to scaler=0 and also changed from directBoot=false to directBoot=true, then ran oaf again. It skipped past the BIOS boot logo but the video output is still the same. It's like oaf is ignoring the scaler parameter completely. Other options like backlight work as expected.

profi200 commented 2 years ago

It seems like you are using an outdated version. The default config should contain the scaler option. Download the latest version again from here and try again. Keep the newline bug in mind i mentioned earlier.

ChainSwordCS commented 2 years ago

It seems like you are using an outdated version. The default config should contain the scaler option. Download the latest version again from here and try again. Keep the newline bug in mind i mentioned earlier.

The commit to add configurable scaling was done in January 2022, but the latest Stable Release is older (December 2021 IIRC).

xgwmir commented 2 years ago

I tried the three options of config.ini file scaler=0 scaler=1 scaler=2, but the screen didn't change anything. I downloaded this version "https://github.com/shinyquagsire23/open_agb_firm/releases/tag/test-sleep-1" His auto-generated config.ini doesn't have a scaler, and I manually added the scaler to a line under the config.ini video, but it doesn't seem to take effect

profi200 commented 2 years ago

Ah, yeah. I totally forgot the latest release doesn't contain this improvement. I will see if i can make a release later.

profi200 commented 2 years ago

A new release is up with the missing scaler option.

ethanchen commented 2 years ago

The scaler is till unavailable on my old 3DS with this file . I also try to delete the old config.init and reboot to check the default config.init, there's no scaler option in the generated file.

ethanchen commented 2 years ago

Sorry, my mistake. I was put the .firm in the wrong path. It works right now.