search

profunktor / fs2-rabbit

:rabbit: RabbitMQ stream-based client built on top of Fs2
https://fs2-rabbit.profunktor.dev/
Apache License 2.0
149 stars 44 forks source link

Feature Request: Add way to setMaxInboundMessageBodySize #990

Open tboon-cfgms opened 2 months ago

tboon-cfgms commented 2 months ago

As data payloads get larger and larger, the default Java client value for maxInboundMessageSize of 64MB is too limiting for some use cases. AMQP spec defines the max message size as 512MB (see https://www.rabbitmq.com/docs/configure#config-items max_message_size). The Java client exposes setMaxInboundMessageSize as a method on ConnectionFactory - Fs2RabbitConfig should allow this value to be set and default to the Java client default of 64MB if not provided.

As an extension of this, add more optional configuration to allow any value in ConnectionFactory to be set beyond those currently supported. But that is a bigger ask.

I would be willing to make a PR for maxInboundMessageSize.

geirolz commented 2 months ago

Hi @tboon-cfgms thanks for reporting this! I think we can have both quite easily but let's start with just maxInboundMessageSize first I would say A PR is welcome for sure

UPDATE: I've just opened a PR to address this https://github.com/profunktor/fs2-rabbit/pull/991