search

profunktor / http4s-jwt-auth

:lock: Opinionated JWT authentication library for Http4s
https://http4s-jwt-auth.profunktor.dev/
119 stars 15 forks source link

Change representation of PrivateKey to not use String #452

Closed hunterpayne closed 1 month ago

hunterpayne commented 2 months ago

Changing the JwtSecretKey class to use an Array of Characters, byte array or PrivateKey.

froth commented 2 months ago

Thanks for your work. First glance looks fine to me, however I am currently on vacation and only have a phone with me ;) I can have another look at some point next week, sorry for the slow response.

@gvolpe any thoughts? I think this is binary breaking as it changes the public interface of JwtSecretKey and in my opinion therefore should be released as 2.0.

gvolpe commented 1 month ago

@froth I leave it up to you guys, I don't use this library at all these days, don't wait for my review :)

froth commented 1 month ago

@hunterpayne thanks for your work. I like the changes and will try and merge them today. I will most likely have to change the base branch to series/2.0. I will try to change your pull request to reflect that, if I don't have the permissions to do so I will have to ask you to do that.