Closed hunterpayne closed 1 month ago
Thanks for your work. First glance looks fine to me, however I am currently on vacation and only have a phone with me ;) I can have another look at some point next week, sorry for the slow response.
@gvolpe any thoughts? I think this is binary breaking as it changes the public interface of JwtSecretKey
and in my opinion therefore should be released as 2.0.
@froth I leave it up to you guys, I don't use this library at all these days, don't wait for my review :)
@hunterpayne thanks for your work. I like the changes and will try and merge them today. I will most likely have to change the base branch to series/2.0. I will try to change your pull request to reflect that, if I don't have the permissions to do so I will have to ask you to do that.
Changing the JwtSecretKey class to use an Array of Characters, byte array or PrivateKey.