search

profusion / apollo-federation-file-upload

Add file upload support to Apollo Federated services.
32 stars 27 forks source link

feat: upgrade dependencies to support Apollo Server 3 and latest Apollo Gateway #38

Closed sjungling closed 2 years ago

sjungling commented 3 years ago

Problem

When attempting to use with a combination of Apollo Server 3.3.x and Apollo Gateway 0.41.x I was running into issues satisfying dependencies version without the use of --force installation (NPM 7).

Solution

Upgrade all dependencies in range (except TypeScript), update tests to conform to Apollo Server 3 config, and use types from Apollo for process and willSendRequest. Also updated some grammatical nuance on the README and updated the example code.

cabelitos commented 3 years ago

@sjungling thank you very much for the PR. Could you please take a look in my comments?

lassesteffen commented 2 years ago

Can we get this merged?

fredleger commented 2 years ago

We desperately need this! Love luck and profit to the one that merge it 😂

cabelitos commented 2 years ago

hey guys, sorry for the long delay. I'll take a look.

lassesteffen commented 2 years ago

With the latest versions of graphql gateway it suddenly stopped worked for me even with this adapted version. Maybe you can check that as well!

cabelitos commented 2 years ago

Hey guys, I close this commit because due to conflicts. However it's included in here ( I fixed the conflicts). https://github.com/profusion/apollo-federation-file-upload/pull/42

I also took the liberty to update all the deps once again, since they are now a little bit outdated.

I bumped all the peers deps to

    "@apollo/gateway": "^0.46.0",
    "apollo-server-env": "^4.2.1",
    "apollo-server-types": "^3.5.1",
    "graphql-upload": "^13.0.0"

Please use version 3.0.0 which is now available on NPM https://www.npmjs.com/package/@profusion/apollo-federation-upload

Sorry for the delay and thank you for your patience

cc: @sjungling @lassesteffen @fredleger