search

profusion / apollo-federation-file-upload

Add file upload support to Apollo Federated services.
32 stars 27 forks source link

Fix sending custom headers #57

Closed burn2delete closed 1 year ago

burn2delete commented 2 years ago

This is a supplemental fix for using custom headers

barbieri commented 2 years ago

hi @flyboarder, would you mind adding a test to cover this case so we don't break it again in the future? Also, please rebase on top of #55, then I'll include your code in that upcoming release (testing that branch is also appreciated!)

cabelitos commented 2 years ago

@barbieri @flyboarder I would also add E2E tests for that as well. Since apollo always changes this path, thus forcing us the heavily update this function.

So, covering it with E2E and unit sounds a very good idea.

dominik-myszkowski commented 1 year ago

This is pretty urgent and blocking. Please approve the change and build a new release as soon as possible....

ccosming commented 1 year ago

What about this PR? is necessary for auth and other stuffs...

Thanks!

rebirthtobi commented 1 year ago

Waiting for this PR

barbieri commented 1 year ago

@oliveirarleo take a look plz

veimox commented 1 year ago

FYI, this PR should not be needed if #66 is merged as they tackle the same problem

g7fernandes commented 1 year ago

Merged on 4.1