Open dsnam opened 1 month ago
@barbieri any chance you will have time to take a look at this soon?
sorry taking so long (busy at work), I'll look at it during the weekend. Thanks for your contribution!!!
just a heads up I didn't forget about this, seems the CI is broken unrelated to this PR... I'll disable older python to see if that comes back to work
sorry, I did click the "update branch as merge", but can you do a rebase? Let me know if that works for you
Totals | |
---|---|
Change from base Build 10801456318: | 0.0% |
Covered Lines: | 1615 |
Relevant Lines: | 1615 |
sorry, I did click the "update branch as merge", but can you do a rebase? Let me know if that works for you
Yep, had to reinstall deps to get the pre-commit tests passing but I think it's set now.
Description
Given a schema like this:
codegen would reject queries with fragments like this:
The check for whether or not a type in a type condition was valid was only based on the interface's
possibleTypes
, which cannot include other interfaces. This adds checking whether the type implements the interface. I believe interfaces used to not be allowed to implement interfaces according to the spec, but this was added some time ago.Related Issues
I did not open an issue or spot a related one. If there are issues with the approach in this PR I can close this and open an issue instead to keep track of it.
Progress
Pull request checklist
How to test it
I added a test that uses a schema and operation file in this PR that reproduces the issue.