profzei / Matebook-X-Pro-2018

💻 Latest macOS on Huawei Matebook X Pro 2018
Apache License 2.0
372 stars 48 forks source link

'Stolen EFI' #208

Closed tlefko closed 4 months ago

tlefko commented 2 years ago

Hi @profzei, I understand I failed to put your name in the credits of the repository. Please look through my previous ones to see I do in fact give credit to original work. I would like to sincerely apologize I genuinely did not realize I forgot to credit you. This EFI of yours does not work for me properly, as trackpad does not consistently work on bootup and the Bluetooth still will not work on Monterey. In my EFI, I made changes to these functions however still haven't fixed the Bluetooth. Please understand I'm not trying to take credit for your work, I genuinely did not realize I omitted it. Thank you for your contributions to the community. Kindly understand there are multiple changes to it including ACPI patches, and which are being used and not. Further, I believe there is a solution to the strange power draw of the touchscreen and thus reenabled it in ACPI. I have attempted to credit you for everything in the post, please let me know if there's anything else I can add to it. Thanks! Like you, I also release these only for personal use and do not profit from posting these. Hope you can understand where I'm coming from. I have done by best to list the changes as they affect the machine from my perspective, but you can obviously see them within the folders.

Unequivocally, multiple changes exist between the EFI I posted and yours, especially within the ACPI section. I did not attempt to 'Steal' your EFI, or your work. There is zero net gain for me doing this whatsoever, and even in my first Mojave repo I literally credited @syscl for what was almost entirely his work. The only goal I have is to simply help people with their machines, in the time I have been doing this (over 4 years) I've barely made a dime. Thank you for bringing to my attention what I forgot to include in the repo, next time feel free to email me or send me a private message if you have any concerns..