search

proget-hq / phpstan-yii2

Yii2 extension for PHPStan
MIT License
52 stars 18 forks source link

Fixed notice for undefined-index #18

Closed EtienneBruines closed 5 years ago

EtienneBruines commented 5 years ago

Without this bugfix, under PHP 7.3.9 with notices enabled, the following is outputted:

$ composer stan

PHP Notice:  Undefined index: request in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: request in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: response in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: response in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: user in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: user in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
EtienneBruines commented 5 years ago

@akondas @marmichalski this PR seems important before the release version 0.6.0.

ghost commented 5 years ago

Thanks ❤️