progfolio / elpaca

An elisp package manager
GNU General Public License v3.0
634 stars 31 forks source link

[Bug/Support]: use-package :ensure keyword does not work as expected #323

Closed ZharMeny closed 3 months ago

ZharMeny commented 3 months ago

Confirmation

Elpaca Version

Elpaca 8bb0fc8 HEAD -> master, origin/master, origin/HEAD installer: 0.7 emacs-version: GNU Emacs 29.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) git --version: git version 2.44.1

Operating System

Linux (NixOS Unstable)

Description

Under normal circumstances (namely, vanilla use-package macro), :ensure keyword implies t unless otherwise specified. Here's an example:

(use-package embark-consult
  :ensure) ; t is implicit

If, however, elpaca-use-package-mode is on, the :ensure keyword does not imply t and you have to manually specify it, which is quite unexpected.

progfolio commented 3 months ago

Thanks for taking the time to fill out a report.

Under normal circumstances (namely, vanilla use-package macro), :ensure keyword implies t unless otherwise specified. Here's an example:

(use-package embark-consult
  :ensure) ; t is implicit

I'm surprised that works and doesn't signal an error. I've patched Elpaca's use-package support to be compatible. Should work on your end after M-x elpaca-update elpaca-use-package followed by M-x restart-emacs. Testing appreciated.

ZharMeny commented 3 months ago

It works, thanks.

progfolio commented 3 months ago

Thank you for testing.