search

proginosko / LeechBlockNG-chrome

LeechBlock NG (Next Generation) for Chrome is a simple productivity tool designed to block those time-wasting sites that can suck the life out of your working day. All you need to do is specify which sites to block and when to block them.
https://www.proginosko.com/leechblock/
Mozilla Public License 2.0
72 stars 14 forks source link

Possible collision with ublock origin - infinite refresh #28

Closed MurtadhaInit closed 3 years ago

MurtadhaInit commented 3 years ago

The issue arose recently when I noticed the blocked tabs are being refreshed instantaneously and continuously, while the ublock origin icon is turning red and grey at the same pace (is it related? I don't know). I did have a rule to refresh blocked websites every 60 seconds (though not every millisecond, obviously!). Things were working fine until very recently. Those blocked pages will just continue to refresh endlessly until the conditions are met (a new hour comes, and they load normally). The blocked websites are facebook and twitter though I don't think it has to do with the websites themselves; Also, those tabs lost their icons sometimes, and chrome would occasionally get stuck when closed (it would close but a process would remain running, needing manual shut down before I can open it again).

proginosko commented 3 years ago

Are you using the setting "Attempt to reload blocked page every __ seconds"?

MurtadhaInit commented 3 years ago

Are you using the setting "Attempt to reload blocked page every __ seconds"?

Yes. Though it is set to 60 seconds.

proginosko commented 3 years ago

Try clearing that setting and disabling uBlock, and see if the problem still arises. Process of elimination...

MurtadhaInit commented 3 years ago

Try clearing that setting and disabling uBlock, and see if the problem still arises. Process of elimination...

I tried clearing that settings and the issue continued to occur. The website is blocked and I get the LeechBlock page instead containing the link of the blocked page, but as soon as I click that link or refresh the page it gets stuck in that endless refreshing loop.

As for ublock I now think it has nothing to do with it, since the blocked page is classified as a "chrome extension" page and ublock origin automatically ignores it (it is disabled there). The flashing of its sign is probably a result of the actual page refreshing endlessly.

proginosko commented 3 years ago

If you can, please provide a series of steps to reproduce the problem from scratch (i.e., the settings for the block set and the URL of a page that triggers the issue). If you want to do so privately, you can email me at leechblockng@proginosko.com.

MurtadhaInit commented 3 years ago

If you can, please provide a series of steps to reproduce the problem from scratch (i.e., the settings for the block set and the URL of a page that triggers the issue). If you want to do so privately, you can email me at leechblockng@proginosko.com.

Windows 10, Chrome Version 88.0.4324.182. There are two rules only: one is to allow fb and twitter for 5mins every hour, then do the "immediate" block. The other is to block youtube between 9am and 3pm for any time exceeding a total of 20mins, but without the "immediate" block option.

The problem occur on all three sites. It is usually triggered when the link in the middle blocked page is clicked (the link of the blocked page, essentially). And sometimes the endless refresh happens without even interacting with the affected tab at all.

desktop11
proginosko commented 3 years ago

Thanks, that's helpful. I was able to reproduce the issue. It turns out it's due to a difference in the way Chrome triggers the webNavigation.onBeforeNavigate event compared with Firefox. It should be a straightforward fix. Stay tuned...

proginosko commented 3 years ago

This should be fixed in version 1.0.11.2, currently pending review.

MurtadhaInit commented 3 years ago

This should be fixed in version 1.0.11.2, currently pending review.

Fixed. Cheers! :)