search

proginosko / LeechBlockNG-chrome

LeechBlock NG (Next Generation) for Chrome is a simple productivity tool designed to block those time-wasting sites that can suck the life out of your working day. All you need to do is specify which sites to block and when to block them.
https://www.proginosko.com/leechblock/
Mozilla Public License 2.0
72 stars 14 forks source link

Treat keywords as allow-conditions issue #48

Open yarkod opened 1 year ago

yarkod commented 1 year ago

Using YouTube Channels ID as allow-condition keyword stopped working recently. Using name of a channel instead of ID works but not if you open tab in background (Open link in new tab)

proginosko commented 1 year ago

Thanks for the report. That may be a consequence of some changes to the code in version 1.5: https://github.com/proginosko/LeechBlockNG-chrome/commit/8f4bfa61ddd131c4a6b80d91f65f1a4407737e33

Basically, only the actual text of the web page should be searched for keywords. If the channel ID doesn't appear in the actual text, it shouldn't trigger the block/allow. So it would be better to use the name of the channel as the keyword.

I don't know about the issue with opening the tab in the background, though. I'll have to investigate that. Which OS are you using?

yarkod commented 1 year ago

Windows 7 ultimate sp1

proginosko commented 5 months ago

Can this be resolved by using the "Wait __ second(s) after page has loaded before checking blocking conditions" advanced option (introduced in version 1.6.3)? Try setting this to 1 or 2 seconds to see if that solves the problem.