search

progit / progit2-es

Spanish Translation
Other
130 stars 87 forks source link

Ebook pub #116

Closed jnavila closed 6 years ago

jnavila commented 6 years ago

Not yet ready for merge

jnavila commented 6 years ago

Well, it passed! @andres-mancera Would you like to review the changes before the merge?

andres-mancera commented 6 years ago

Thanks @jnavila ! So you want me to go over the 489 changed files, review them and bless this merge? 😆 It'll be probably easier to merge and then go over the book and fix any issues at that point. What do you think?

jnavila commented 6 years ago

Well, most of the changes are only cross-ref updates and removals of remainings of conflicts marks. That's mainly for what's left that I'm not sure of. I guess we can merge.

andres-mancera commented 6 years ago

Cool, thanks a lot! Will the book get built now every time there is a commit? If so, where can we find the latest version of the book?

jnavila commented 6 years ago

The book is built only on tags. Tags are automatically created on master only. Books are available at https://github.com/progit/progit2-es/releases and the url will be daily updated on git-scm.com.

andres-mancera commented 6 years ago

If I remember correctly, the book that was generated by the old build process contained a page that basically came directly from the contributors file. I no longer see that as part of the new book. Any idea what happened? IMO, having the names of the translators as part o the book was a nice token of appreciation.

jnavila commented 6 years ago

It can still be added.

jnavila commented 6 years ago

The trick here is that it has to be extracted from the present repository and won't reflect the contributors to the original book.

jnavila commented 6 years ago

The list is generated automatically now. You can modify the people appearing by changing the .mailmap file.