progit / progit2-zh

Other
1.44k stars 357 forks source link

Warning but not quit after URL check #518

Open networm opened 1 month ago

networm commented 1 month ago

Our action build failed after url check 遵循原文 修改ruby脚本过时的代码 · progit/progit2-zh@55231ea

But english repo has no problem Merge pull request #1970 from z-hed/notepad++ · progit/progit2@b3af68c

It seems that url check only output warnings, but not quit

HTML-Proofer found 8 failures!
Command failed with status (1): [htmlproofer progit.html]
Error when checking books (ignored)

Could you help us to just ignore this check? @jnavila Maybe it could be like this: Fix htmlproofer invocation · progit/progit2@8de1de7

Sherry520 commented 3 weeks ago

I submitted a PR #520 to solve the building failure problem. Here is how I resolved it:

Sherry520 commented 3 weeks ago

Everything seems to be working fine. #520 https://github.com/progit/progit2-zh/actions/runs/10416702456/job/28849460914

Sherry520 commented 3 weeks ago

现在应该可以build和release成功了,晚上又不小心改动了字体库那边文件的名字,给它恢复并存档了,以后没问题的话,我就不动它了。