Enable .mobi (Kindle) format again - Githubissues

progit / progit2

Pro Git 2nd Edition

Other

5.79k stars 1.9k forks source link

Enable .mobi (Kindle) format again #1655

Closed HonkingGoose closed 3 years ago

HonkingGoose commented 3 years ago

[x] I provide my work under the project license.
[x] I grant such license of my work as is required for the purposes of future print editions to Ben Straub and Scott Chacon.

Changes

Enable .mobi (Kindle) format again
Add references to mobi files back in README
Add mobi rake build command to README

Context

Fixes #1528

asciidoctor-epub3 has the Kindlegen dependency in it again, so we can enable mobi builds again. (https://github.com/progit/progit2/pull/1646#issuecomment-828968577)

Please check if this change alone is enough to get things working.

@slonopotamus @jnavila can you please check my work?

slonopotamus commented 3 years ago

Looks OK

jnavila commented 3 years ago

In fact, the mobi file is missing in the cleaning task!

HonkingGoose commented 3 years ago

@jnavila can you point me to what went wrong?

EDIT: I found the code you're mentioning:

https://github.com/progit/progit2/blob/5eb9b0cd9a100fa217865431ba672e6f039ce781/Rakefile#L109-L125

You're right it's missing here!

HonkingGoose commented 3 years ago

I think the refactoring PR #1598 made some more changes, so that just inserting the old code is no longer working properly....