progit / progit2

Pro Git 2nd Edition
Other
5.79k stars 1.9k forks source link

resolves #1671 install Kindlegen so .mobi output can be produced #1672

Closed slonopotamus closed 3 years ago

slonopotamus commented 3 years ago
HonkingGoose commented 3 years ago

Oh there's a spelling error in the commit message:

Benefits:
1. Command is printed to stdout, so it is clear what is bein execured
2. Whole build will fail if any command fails

Might want to force-push a better commit message?

Benefits:
1. Command is printed to stdout, so it is clear what is being executed
2. Whole build will fail if any command fails
slonopotamus commented 3 years ago

Whoops. Fixed.

HonkingGoose commented 3 years ago

I'd say this is ready for review by @ben now. 😉

ben commented 3 years ago

✨

HonkingGoose commented 3 years ago

That seems to have done the trick, we're publishing .mobi files again! 🚀

Thank you very, very, very much @slonopotamus for your hard work on getting the kindlegen gem working again, and for your help with getting our .mobi build working again! 🎉 ✨ ✨