Modernize recommendation for credential store

progit / progit2

Pro Git 2nd Edition

Other

5.77k stars 1.9k forks source link

Closed vtbassmatt closed 2 years ago

vtbassmatt commented 2 years ago

GCM for Windows (along with GCM for macOS/Linux) has been replaced with the cross-platform GCM Core.

[x] I provide my work under the project license.
[x] I grant such license of my work as is required for the purposes of future print editions to Ben Straub and Scott Chacon.

Remove mention of "GCM for Windows", replace with "GCM Core".

GCM for Windows has been superseded GCM Core. GCM for Windows is deprecated and no longer supported.

dscho commented 2 years ago

Oh, I see... https://github.com/progit/progit2/pull/1724 already does what I suggested...

vtbassmatt commented 2 years ago

@ben or @schacon, would you consider this small improvement?

dscho commented 2 years ago

dscho approved these changes 35 seconds ago

In case it was unclear: I am not some random drive-by reviewer, I reviewed this in my role as the maintainer of Git for Windows.

ben commented 2 years ago

I like it. Thanks!