progit / progit2

Pro Git 2nd Edition
Other
5.77k stars 1.9k forks source link

line break issue in <code> tags on online html copy of progit 2 #1714

Open Stinger-au opened 2 years ago

Stinger-au commented 2 years ago

There's no existing/similar bug report.

This report is about a single actionable bug.

This report is about the ProGit book, version 2, English language.

Bug covers book website/pdf

Problem is present in the Pro Git book on the website?

Which version of the book is affected?

I don't know

Describe the bug:

When reading through the online copy I notice that a lot of the code tags break lines in odd places, sometimes particularly bad places like in the middle of numbers as in the example image below.

I think this is from the css property word-break: break-all; on these \<code>-tags - Now I can half understand why you might want this, as on low width devices long strings (such as sha hashes) might not break across. Although if I minimize my window width (on desktop ff), the sha1 strings just force the code blocks to include a scrollbar anyway and hide overflow rather than wrap.

I had a look and I couldnt see that anyone had brought this up before.

example image

Steps to reproduce:

  1. Go to '...'
  2. Click on '...'
  3. 'Scroll down to '...'
  4. See error

Expected behavior:

No line breaks in the middle of words/numers/program identifiers.

Screenshots:

No response

Additional context:

No response

Device

No response

Operating system

Win 10 Pro

Browser/application + version

Firefox 94.0.1 (64-bit)