progit / progit2

Pro Git 2nd Edition
Other
5.77k stars 1.9k forks source link

update link #1716

Open benkoshy opened 2 years ago

benkoshy commented 2 years ago

(Note: running GET info/refs after cloning the repository yeilds unexpected results for me: the command line dumps html which seems to want for me to prove i'm a human via a recaptcha test? Not sure what to do about that)

ben commented 2 years ago

What this section is describing isn't of any practical value at this point in history. GitHub turned off the insecure dumb-http protocol 10 years ago, so you'll have to stand up your own Git HTTP server to be able to test any of this yourself. The section is about how clone works in a conceptual way, not in a manually-reproducible way.

Given that, I'm of two minds about this patch. On the one hand, giving a real repo people can visit to see what the commands are talking about is nice. On the other hand, it sends a mixed signal that you should be able to follow along in a shell, when you actually can't. What do you think?

benkoshy commented 2 years ago

On the other hand, it sends a mixed signal that you should be able to follow along in a shell, when you actually can't. What do you think?

Agreed - following along / experimenting in the shell is a nice learning experience. because I was attempting to follow along manually (e.g. typing in commands) -- and given nothing worked (the link was wrong? and when i found the link it did not work - presumably because, as stated, github turned off that feature 10 years ago), I was very confused - the train of thought might have gone something like this: "am i doing something wrong? i'm a newbie learning git and something doesn't seem right. shrugs shoulders"

What do you think?

To answer your question, I can enumerate a few ideas:

Since this is your project/creation ultimately it's your call - I figured I would merely present my ideas as a reader. (btw i thank you for work efforts on the book etc).

i would be curious to know your thoughts, and i would not be averse to further PRs / working on these ideas if required (depending on my capacity).