search

progit / progit2

Pro Git 2nd Edition
Other
5.81k stars 1.92k forks source link

Possibly incorrect URLs #339

Open Zer0t3ch opened 9 years ago

Zer0t3ch commented 9 years ago

In book/07-git-tools/sections/submodules.asc, shouldn't each reference to a git repository (in this case, https://github.com/chaconinc/DbConnector) end with .git? (https://github.com/chaconinc/DbConnector.git)

ben commented 9 years ago

This is a feature/peculiarity of GitHub-hosted repos; if Git makes the HTTP request, the server doesn't care if you include the .git suffix or not, it'll behave the same way. So you can copy-paste your URL bar into a command line, and it'll just work. Other hosts might do the same thing, I know Bitbucket does.

So this isn't technically a problem, but maybe it could be a bit clearer. Want to submit a PR with a correction, or maybe a note about the behavior?

dmitris commented 8 years ago

another problem is that https://github.com/chaconinc/DbConnector is no longer available - gives a 404. https://github.com/chaconinc/ says: "This organization has no public repositories."

ben commented 8 years ago

Ooh. Good catch. Anyone want to rewrite those URLs to something that exists?

Zer0t3ch commented 8 years ago

@ben Why not rewrite them to this repo? (to keep things simple)

YueLinHo commented 8 years ago

TortoiesGit has these submodules, choice one?

https://github.com/apache/apr-util.git
https://gitlab.com/tortoisegit/apr.git
https://gitlab.com/tortoisegit/tgit.git
https://github.com/madler/zlib.git
https://github.com/libgit2/libgit2.git
http://anongit.freedesktop.org/git/libreoffice/dictionaries.git
https://github.com/editorconfig/editorconfig-core-c.git
https://gitlab.com/tortoisegit/pcre.git
https://chromium.googlesource.com/external/gtest.git

How about libgit2 or zlib?

ben commented 8 years ago

Libgit2 is a good choice, it should be public forever.

YueLinHo commented 8 years ago

But TortoiseGit is a little big (too many submodule in it) for a example. See long example:

[source,console]
----
$ git clone https://gitlab.com/tortoisegit/tortoisegit.git
Cloning into 'tortoisegit'...
remote: Counting objects: 69960, done.
remote: Compressing objects: 100% (17486/17486), done.
remote: Total 69960 (delta 53396), reused 68667 (delta 52266)
Receiving objects: 100% (69960/69960), 90.35 MiB | 920.00 KiB/s, done.
Resolving deltas: 100% (53396/53396), done.
Checking connectivity... done.
Checking out files: 100% (3477/3477), done.

$ cd tortoisegit
$ cd ext
$ ls -la
total 93
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 ./
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 ../
-rw-r--r-- 1 Administrator 197121   23 Mar 15 14:38 .gitattributes
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 CrashServer/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 OGDF/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 ResizableLib/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 TortoiseOverlays/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 apr/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 apr-util/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 build/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 editorconfig/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 gitdll/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 gtest/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 hunspell/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 libgit2/
-rw-r--r-- 1 Administrator 197121 4427 Mar 15 14:38 libgit2-0001-core.autocrlf-true-and-core.safecrlf-true-did-not-fa.patch
-rw-r--r-- 1 Administrator 197121 1411 Mar 15 14:38 libgit2-0002-core.autocrlf-is-not-correctly-initialized-on-Win32-.patch
-rw-r--r-- 1 Administrator 197121 2378 Mar 15 14:38 libgit2-0003-Adding-a-CRLF-file-with-core.autocrlf-input-and-core.patch
-rw-r--r-- 1 Administrator 197121 2889 Mar 15 14:38 libgit2-0004-Make-files-with-CR-CRLF-not-fail-with-core.safecrlf-.patch
-rw-r--r-- 1 Administrator 197121 4609 Mar 15 14:38 libgit2-0005-Make-CRLF-filter-behave-like-vanilla-git-for-adding-.patch
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 pcre/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 putty/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 scintilla/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 spell/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 tgit/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 tools/
drwxr-xr-x 1 Administrator 197121    0 Mar 15 14:38 zlib/

$ cd zlib/
$ ls
$
----

and

[source,console]
----
$ git submodule init
Submodule 'ext/apr' (https://gitlab.com/tortoisegit/apr.git) registered for path '../apr'
Submodule 'ext/apr-util' (https://github.com/apache/apr-util.git) registered for path '../apr-util'
Submodule 'ext/editorconfig' (https://github.com/editorconfig/editorconfig-core-c.git) registered for path '../editorconfig'
Submodule 'ext/gtest' (https://chromium.googlesource.com/external/gtest.git) registered for path '../gtest'
Submodule 'ext/libgit2' (https://github.com/libgit2/libgit2.git) registered for path '../libgit2'
Submodule 'ext/pcre' (https://gitlab.com/tortoisegit/pcre.git) registered for path '../pcre'
Submodule 'ext/spell' (http://anongit.freedesktop.org/git/libreoffice/dictionaries.git) registered for path '../spell'
Submodule 'ext/tgit' (https://gitlab.com/tortoisegit/tgit.git) registered for path '../tgit'
Submodule 'ext/zlib' (https://github.com/madler/zlib.git) registered for path '../zlib'

$ git submodule update
Cloning into 'ext/apr'...
remote: Counting objects: 72637, done.
remote: Compressing objects: 100% (25424/25424), done.
remote: Total 72637 (delta 46011), reused 72637 (delta 46011)
Receiving objects: 100% (72637/72637), 18.79 MiB | 908.00 KiB/s, done.
Resolving deltas: 100% (46011/46011), done.
Checking connectivity... done.
Submodule path '../apr': checked out '69ac608d0580b324f0a572d65db6a92304da787c'
Cloning into 'ext/apr-util'...
remote: Counting objects: 17086, done.
remote: Total 17086 (delta 0), reused 0 (delta 0), pack-reused 17086
Receiving objects: 100% (17086/17086), 8.10 MiB | 904.00 KiB/s, done.
Resolving deltas: 100% (9532/9532), done.
Checking connectivity... done.
Submodule path '../apr-util': checked out 'ca83ff5fbeb9c27454b4f0242f17ebf584ed0521'
Cloning into 'ext/editorconfig'...
remote: Counting objects: 2203, done.
remote: Total 2203 (delta 0), reused 0 (delta 0), pack-reused 2203
Receiving objects: 100% (2203/2203), 522.07 KiB | 230.00 KiB/s, done.
Resolving deltas: 100% (1234/1234), done.
Checking connectivity... done.
Submodule path '../editorconfig': checked out '6c1644d1c48e6b677fecb7a86482ad2159a1348c'
Cloning into 'ext/gtest'...
remote: Total 4351 (delta 3292), reused 4351 (delta 3292)
Receiving objects: 100% (4351/4351), 1.30 MiB | 0 bytes/s, done.
Resolving deltas: 100% (3292/3292), done.
Checking connectivity... done.
Submodule path '../gtest': checked out '86dec5c00225b34a0061127e5cc35b6cf1485b79'
Cloning into 'ext/libgit2'...
remote: Counting objects: 68298, done.
remote: Compressing objects: 100% (19881/19881), done.
remote: Total 68298 (delta 47475), reused 67913 (delta 47090), pack-reused 0
Receiving objects: 100% (68298/68298), 30.72 MiB | 874.00 KiB/s, done.
Resolving deltas: 100% (47475/47475), done.
Checking connectivity... done.
Submodule path '../libgit2': checked out '9f4e7c84904030ecc7d14637fa8c51bac087fedf'
Cloning into 'ext/pcre'...
remote: Counting objects: 13424, done.
remote: Compressing objects: 100% (7207/7207), done.
remote: Total 13424 (delta 7725), reused 11908 (delta 6209)
Receiving objects: 100% (13424/13424), 28.06 MiB | 851.00 KiB/s, done.
Resolving deltas: 100% (7725/7725), done.
Checking connectivity... done.
Submodule path '../pcre': checked out '3f38da524be6f97b8852b3b538317da9891bab29'
Cloning into 'ext/spell'...
remote: Counting objects: 10018, done.
remote: Compressing objects: 100% (5535/5535), done.
remote: Total 10018 (delta 5654), reused 6488 (delta 3623)
Receiving objects: 100% (10018/10018), 117.30 MiB | 1.13 MiB/s, done.
Resolving deltas: 100% (5654/5654), done.
Checking connectivity... done.
Submodule path '../spell': checked out 'e26e5fc152b0a8362040f1daf53088c35ebbe4e1'
Cloning into 'ext/tgit'...
remote: Counting objects: 186720, done.
remote: Compressing objects: 100% (52297/52297), done.
remote: Total 186720 (delta 134699), reused 184463 (delta 132474)
Receiving objects: 100% (186720/186720), 66.38 MiB | 895.00 KiB/s, done.
Resolving deltas: 100% (134699/134699), done.
Checking connectivity... done.
Submodule path '../tgit': checked out '5d12f1f4c5ef744ba294796a397d3eae429720c8'
Cloning into 'ext/zlib'...
remote: Counting objects: 4367, done.
remote: Total 4367 (delta 0), reused 0 (delta 0), pack-reused 4367
Receiving objects: 100% (4367/4367), 2.52 MiB | 755.00 KiB/s, done.
Resolving deltas: 100% (2974/2974), done.
Checking connectivity... done.
Submodule path '../zlib': checked out '50893291621658f355bc5b4d450a8d06a563053d'
----

and got some fatal clone message sometimes:

[source,console]
----
$ git clone --recursive https://gitlab.com/tortoisegit/tortoisegit.git
Cloning into 'tortoisegit'...
remote: Counting objects: 69960, done.
[...]
Checking connectivity... done.
Checking out files: 100% (3477/3477), done.
[...]
Submodule path 'ext/editorconfig': checked out '6c1644d1c48e6b677fecb7a86482ad2159a1348c'
Submodule 'tests' (git://github.com/editorconfig/editorconfig-core-test.git) registered for path 'tests'
Cloning into 'tests'...
fatal: unable to connect to github.com:
github.com[0: 192.30.252.128]: errno=No error

fatal: clone of 'git://github.com/editorconfig/editorconfig-core-test.git' into submodule path 'tests' failed
Failed to recurse into submodule path 'ext/editorconfig'
----

I'd like to create a repo in my account or under progit for a dummy repository. How about it?

KZiemian commented 2 years ago

Should I add making pull request for this issue to my TODO list? It doesn't mean that I will be able to do it, but I plan to acquire enough Git knowledge to be able to do that, without messing things up.

ben commented 2 years ago

Yeah, I'd accept a PR that fixes this.