search

proglottis / ladder

Ladder tournament ranking website
ladders.pw
MIT License
19 stars 17 forks source link

Request access to join tournament #25

Closed jtwalters closed 11 years ago

jtwalters commented 11 years ago

How difficult would it be to list all tournaments with a "request invitation" type link? As it is now, you have to know someone's email address to invite them to a tournament. But, I think it might be useful to allow people to sign in and then request invites to any tournament they're interested in.

proglottis commented 11 years ago

Yup I agree. This would be a cool feature. I've had people ask for it before.

Shouldn't be hard to do. Add a public flag to tournaments. Create a new model for invite requests. Add a public tournament listing UI and a invite request admin for the tournament owner. Better to just use the existing invite mechanism for now.

In a later change public tournaments could even be available to unauthenticated users - Maybe just showing the ratings.

Pull requests are always welcome :)

jtwalters commented 11 years ago

Can you elaborate a little on:

Better to just use the existing invite mechanism for now.

I would like to add some or all of this in a pull request, if I have time, but I want to be sure I am doing it right.

proglottis commented 11 years ago

I can help you out if you like.

I just meant instead of adding the player and ratings directly, you can just create an invite and send the email. Saves having the player creation code in a bunch of different places. Can always change it later if this is too awkward.

jtwalters commented 11 years ago

Merged in PR #29