Git hooks: treating warnings as error

progmaticltd / homebox

A set of ansible scripts to build a personal mail server / private cloud / etc.

https://homebox.space/

GNU General Public License v3.0

465 stars 52 forks source link

Git hooks: treating warnings as error #320

Closed fredericmoulins closed 4 years ago

fredericmoulins commented 4 years ago

The second step for the hooks. Should help catch imports or includes of missing ansible files.

Please find some more details in the commit messages.

arodier commented 4 years ago

Thanks, testing it right now.

fredericmoulins commented 4 years ago

Ok, I force-pushed on the PR:

/bin/sh, avoiding pipes ;
reduced ansible-lint log on the console to errors and warnings only ;
logs are gathered in one file for pre-commit, one for pre-push ;
xargs is used in both cases to have ansible run on each file, so it can output errors or warnings for all files.

arodier commented 4 years ago

If you feel we reached the limit of gnu dash, maybe we can write some clean hook in ~~perl~~ python ;-). TBH, that's probably the best option on the long term. CI is making good progress...