prograils / lit

rails i18n web interface
MIT License
298 stars 71 forks source link

Refactory messy`store_item` method #157

Open mlitwiniuk opened 4 years ago

mlitwiniuk commented 4 years ago

This store_item method looks too messy to me. Maybe you could 1. remove commented transaction block 2. extract this lengthy conditional to separate method? However this would require handling startup_process variable differently. To be honest if startup_process is true most of this method is skipped entirely. Maybe startup_process can live in Lit.startup_process?

_Originally posted by @pnikrat in https://github.com/prograils/lit/pull/130#discussion_r516592340_