search

programatik29 / axum-server

High level server designed to be used with axum framework.
MIT License
177 stars 63 forks source link

upgrade to rustls 0.22.1, tokio-rustls 0.25.0 #106

Closed eric-seppanen closed 2 months ago

eric-seppanen commented 9 months ago

I'm not sure if there's any interest in doing this, because it would be a major breaking change and the 0.6 release just went out a few weeks ago.

But since I went through the motions of making it work, I figured I'd at least post this so others could decide whether this change was desirable.

I have tested it in my own axum project, and it seemed to work, but I can't attest to more than that.

diptanu commented 7 months ago

What is the status of this thing? I had to revert to rustls 0.21 because of the incompatibilities.

eric-seppanen commented 7 months ago

rustls 0.23 is out now, so this PR is probably not of much use except as a starting point for working on the next upgrade.

MaxFangX commented 6 months ago

Thanks for this; we are adopted these changes as a patch in our crate graph during our process of upgrading to rustls@0.22. Major parts of the ecosystem haven't upgraded to 0.23 yet (including crates like reqwest and hyper-rustls), and if others have a relatively deep integration with rustls like us, they will have issues with client and server TLS configs being incompatible. Because of this, there is value in merging this PR so there is a version of axum-server published on crates.io that uses rustls@0.22. But maybe this is a problem experienced only by a marginal number of users which happens to include us. We've worked around it anyhow; just sharing our perspective.

programatik29 commented 2 months ago

124 closes this.