search

programatik29 / axum-server

High level server designed to be used with axum framework.
MIT License
166 stars 54 forks source link

axum 0.7.x support #92

Closed crwn1337 closed 7 months ago

crwn1337 commented 7 months ago

axum got updated and tls examples aren't working https://github.com/tokio-rs/axum/blob/2e963cea9d35cd6b2583670146d25842db1f3618/examples/tls-rustls/src/main.rs#L30

yuhaya commented 7 months ago

same

crwn1337 commented 7 months ago

it got updated to support 0.7.x, but here's a little nitpick: https://github.com/programatik29/axum-server/blob/bb18fcc94e692e2b8a8ad0ca2d5aa6741616e790/src/server.rs#L146 to avoid calling unwrap(), it should be:

handle.notify_listening(incoming.local_addr().ok());
abs0luty commented 7 months ago

@crwn1337 Thanks for pointing this out! ❤. Will bump the new version in 2-3 days.

eric-seppanen commented 7 months ago

Are there additional changes needed to support axum 0.7? If not, could there be a new release of axum-server?